Typescript return type of web3.eth.accounts.signTransaction() is incorrect.

[lucashenning]

Expected behavior

The return type of web3.eth.accounts.signTransaction(tx,privateKey)
should be Promise<{ messageHash, v, r, s, rawTransaction }>,
not Promise<string> | Signature

Actual behavior

web3.eth.accounts.signTransaction(tx,privateKey) returns string | Signature

Steps to reproduce the behavior

The following code works perfectly but signedTx.rawTransaction throws a type error during typescript compilation.

let deployTx : TransactionObject<Contract> = contract.deploy({
        data: contractJson.bytecode,
        arguments: []
    });
let tx : Tx = {
        from: accountAddress,
        data: txObject.encodeABI(),
        gas : await deployTx.estimateGas(),
        value : 0
    };
let signedTx = await web3.eth.accounts.signTransaction(tx,privateKey);
web3.eth.sendSignedTransaction(signedTx.rawTransaction)

Error Logs

{"message": "Property 'rawTransaction' does not exist on type 'string | Signature'.\n Property 'rawTransaction' does not exist on type 'string'.", }

Versions

Node v11.7.0
npm v6.7.0
web3 v1.0.0-beta.34

[lucashenning]

Fixed in #2217 and merged in ec585b1

Thanks @joshstevens19