Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web3.eth.getBlock return Block type in typescript have misleading transaction property #2819

Closed
averman opened this issue May 15, 2019 · 3 comments
Closed

web3.eth.getBlock return Block type in typescript have misleading transaction property #2819

averman opened this issue May 15, 2019 · 3 comments
Labels
Types Incorrect or missing types

Comments

@averman
Copy link

averman commented May 15, 2019

https://github.com/ethereum/web3.js/blob/9714f30869d2ba6d1a7bc80df67a029694b2abc3/packages/web3-eth/types/index.d.ts#L191

in here the Block type have transaction type is array of Transaction; but when returned by web3.eth.getBlock() the type is array of string.

suggestion: make it union type of Transaction and string
@nivida nivida added the Types Incorrect or missing types label May 15, 2019
@joshstevens19
Copy link
Contributor

Hey thanks for raising this issue. Brilliant spot i will do a PR now for this.

@joshstevens19 joshstevens19 mentioned this issue May 25, 2019
Merged
15 tasks
@joshstevens19
Copy link
Contributor

This has been fixed here - #2844 @nivida will merge that when he has a second.

@joshstevens19
Copy link
Contributor

merged.

@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nivida @averman @joshstevens19