Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing IBAN library to ethereumjs-icap #377

Closed
frozeman opened this issue Jan 20, 2016 · 5 comments
Closed

Changing IBAN library to ethereumjs-icap #377

frozeman opened this issue Jan 20, 2016 · 5 comments
Assignees
Labels
1.x 1.0 related issues 2.x 2.0 related issues Needs Clarification Requires additional input Stale Has not received enough activity

Comments

@frozeman
Copy link
Contributor

This issue is here as a "take a look later" reminder
@axic

@frozeman frozeman added the Enhancement Includes improvements or optimizations label Jan 20, 2016
@frozeman frozeman added this to the 1.0 milestone Jan 20, 2016
@axic
Copy link
Contributor

axic commented Jan 20, 2016

@frozeman you might want to check out ethereumjs/ethereumjs-icap#1 for discussing a new API

@axic
Copy link
Contributor

axic commented Mar 15, 2016

@frozeman released a brand new version (0.2.0) which enforces the 0x prefix and expects fixed length hex addresses. That should be easier to integrate.

@frozeman frozeman modified the milestones: 1.1, 1.0 Aug 9, 2017
@frozeman
Copy link
Contributor Author

frozeman commented Aug 9, 2017

I am not sure if it makes sense to switch to your library, or keep what we have in web3.js now: https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth-iban/src/index.js

@frozeman frozeman changed the title Adding https://github.com/ethereumjs/ethereumjs-icap as dependency ? Changing IBAN library to ethereumjs-icap Aug 9, 2017
@frozeman frozeman removed the Enhancement Includes improvements or optimizations label Aug 9, 2017
@onbjerg
Copy link
Contributor

onbjerg commented Nov 25, 2017

Sorry if this is a common question, but why are ICAP-related functions even bundled in Web3 in the first place? Surely an external library would suffice?

@nivida nivida self-assigned this Aug 10, 2018
@nivida nivida removed this from the 1.1 milestone Nov 30, 2018
@nivida nivida added Needs Clarification Requires additional input and removed Milestone Progress labels Jun 12, 2019
@nivida nivida added 1.x 1.0 related issues 2.x 2.0 related issues labels Jun 20, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues 2.x 2.0 related issues Needs Clarification Requires additional input Stale Has not received enough activity
Projects
None yet
Development

No branches or pull requests

4 participants