-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing IBAN library to ethereumjs-icap #377
Comments
@frozeman you might want to check out ethereumjs/ethereumjs-icap#1 for discussing a new API |
@frozeman released a brand new version (0.2.0) which enforces the 0x prefix and expects fixed length hex addresses. That should be easier to integrate. |
I am not sure if it makes sense to switch to your library, or keep what we have in web3.js now: https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth-iban/src/index.js |
Sorry if this is a common question, but why are ICAP-related functions even bundled in Web3 in the first place? Surely an external library would suffice? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions |
This issue is here as a "take a look later" reminder
@axic
The text was updated successfully, but these errors were encountered: