From f339e004df057664da2dc98207c42baf4c916d0f Mon Sep 17 00:00:00 2001 From: wbt Date: Tue, 8 Mar 2022 12:27:57 -0500 Subject: [PATCH 1/4] Make disconnect params optional in types --- packages/web3-core-helpers/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web3-core-helpers/types/index.d.ts b/packages/web3-core-helpers/types/index.d.ts index 2a072af3bc1..1bfbf5079ac 100644 --- a/packages/web3-core-helpers/types/index.d.ts +++ b/packages/web3-core-helpers/types/index.d.ts @@ -117,7 +117,7 @@ export class WebsocketProviderBase { reset(): void; - disconnect(code: number, reason: string): void; + disconnect(code?: number, reason?: string): void; connect(): void; From 67032bc9bad2700b1f3ebfc2a6562a5048074a92 Mon Sep 17 00:00:00 2001 From: wbt Date: Tue, 8 Mar 2022 13:19:51 -0500 Subject: [PATCH 2/4] Update changelog, including PR number --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f93eda04b2..35bcc8d2563 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -521,5 +521,8 @@ Released with 1.0.0-beta.37 code base. - Ran `npm audit fix` to address vulnerabilities and update libraries (#4719) (#4728) ## [Unreleased] +### Fixed +Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833) + -## [1.8.0] \ No newline at end of file +## [1.8.0] From f3c91179271b84143df4d6c6ea36a4513faa33ab Mon Sep 17 00:00:00 2001 From: WBT Date: Tue, 8 Mar 2022 18:08:57 -0500 Subject: [PATCH 3/4] Update refs to old discussions, mostly just to kick off CI again. --- CONTRIBUTIONS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTIONS.md b/CONTRIBUTIONS.md index 048fdb5918d..11727cb32a9 100644 --- a/CONTRIBUTIONS.md +++ b/CONTRIBUTIONS.md @@ -48,4 +48,5 @@ Emergency releases are allowed to shorten waiting periods depending on the sever There is precedent set for this in the 1.2.6 release (see [#3351](https://github.com/ethereum/web3.js/pull/3351)), where the consensus view was to make the smallest change necessary to address the emergency while waiving the `rc` process (meaning many existing additions to master were excluded). -This topic is under further org-wide discussion at [ethereum/js-organization#6](https://github.com/ethereum/js-organization/issues/6). +This topic was under further org-wide discussion [here](https://github.com/ethereum/js-organization/issues/6) +and [here](https://github.com/ChainSafe/web3.js/issues/3358). From 4778983f13ca209ef4e0ebcde903dcda289709f0 Mon Sep 17 00:00:00 2001 From: Junaid <86780488+jdevcs@users.noreply.github.com> Date: Thu, 17 Mar 2022 18:12:37 +0100 Subject: [PATCH 4/4] PR under 1.7.2 --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f996346477b..c354fc0bcd8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -522,8 +522,8 @@ Released with 1.0.0-beta.37 code base. - Ran `npm audit fix` to address vulnerabilities and update libraries (#4719) (#4728) ## [Unreleased] -### Fixed -Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833) +## [1.7.2] -## [1.8.0] +### Fixed +Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833)