Merge pull request #96 from web3ui/fix-LinkTo-Button-optional-defaults

Fix link to button optional defaults
web3ui · Jan 25, 2022 · 0323611 · 0323611
2 parents 7e8b8e8 + c8efcd7
commit 0323611
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
@@ -10,7 +10,7 @@ const Button: React.FC<ButtonProps> = ({
     iconLayout = 'leading',
     id,
     isFullWidth = false,
-    onClick,
+    onClick = (e) => e.preventDefault(),
     size = 'regular',
     text = 'click',
     theme,

diff --git a/src/components/Button/types.ts b/src/components/Button/types.ts
@@ -9,7 +9,7 @@ export interface ButtonProps {
     /**
      * the function to be called on click
      */
-    onClick: (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => void;
+    onClick?: (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => void;
 
     /**
      * set the button to be interactive, or not

diff --git a/src/components/Form/types.ts b/src/components/Form/types.ts
@@ -20,7 +20,7 @@ export interface FormProps {
     /**
      * Pass all the props a button could use
      */
-    buttonConfig: ButtonProps;
+    buttonConfig?: ButtonProps;
 
     /**
      * when the form passes validation the data is returned

diff --git a/src/components/LinkTo/LinkTo.tsx b/src/components/LinkTo/LinkTo.tsx
@@ -8,7 +8,7 @@ import { LinkStyled, FlexSpanStyled } from './LinkTo.styles';
 const LinkTo: React.FC<LinkToProps> = ({
     address,
     text,
-    type,
+    type = 'external',
     iconLayout = 'leading',
 }) => (
     <LinkStyled

diff --git a/src/components/LinkTo/types.ts b/src/components/LinkTo/types.ts
@@ -18,7 +18,7 @@ export interface LinkToProps {
     /**
      * set to an email link or a link to another website
      */
-    type: TTypeState;
+    type?: TTypeState;
 
     /**
      * set the position of the icon, or icon only