Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: all mono icons now accept fill with currentColor #1002

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix: all mono icons now accept fill with currentColor #1002

merged 1 commit into from
Jan 13, 2023
+292 −426

Conversation

KristamMoffett
Copy link
Collaborator

@KristamMoffett KristamMoffett commented Jan 13, 2023 •
edited
Loading

name: Fix: all mono icons now accept fill with currentColor

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

  • Multiple mono icons were not able to accept currentColor
  • Some API icons had unwanted background colours

Solution Description

  • housekeeping on all SVGs and rebuild of icon gallery

@KristamMoffett KristamMoffett self-assigned this Jan 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: 7954389

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/core/dist/index.js 341.69 KB (0%)
packages/icons/dist/index.es.js 135.66 KB (+0.48% 🔺)
packages/web3/dist/index.js 1.51 MB (0%)
packages/web3uikit/dist/index.js 1.96 MB (+0.04% 🔺)

@KristamMoffett KristamMoffett removed the request for review from BillyG83 January 13, 2023 16:55
@KristamMoffett KristamMoffett merged commit 2dbdb64 into master Jan 13, 2023
@KristamMoffett KristamMoffett deleted the fix-icons-current-color branch January 13, 2023 16:56
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KristamMoffett KristamMoffett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KristamMoffett