Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd: Modal #80

Merged
merged 1 commit into from
Jan 21, 2022
Merged

upd: Modal #80

merged 1 commit into from
Jan 21, 2022

Conversation

Y0moo
Copy link
Collaborator

@Y0moo Y0moo commented Jan 21, 2022 •
edited
Loading

Added:

  • position: fixed for displaying the Modal component correctly (see bug bellow)
  • background blur for better UX
  • interactive Modal Story

Changes:

  • Instead of using the Stories for testing I've used <Modal /> component because we cannot use Storybook preview hooks (useArgs()) outside <Story>. I've provided all args directly to the component

bug:
image

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/web3uikit.cjs.production.min.js 245.47 KB (+0.03% 🔺)
dist/web3uikit.esm.js 332.31 KB (+0.03% 🔺)

BillyG83
BillyG83 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@BillyG83 BillyG83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @Y0moo i love the new args trick and the testing is cool too, nice one dude, great contribute on this PR

@BillyG83 BillyG83 merged commit f2457e3 into master Jan 21, 2022
@BillyG83 BillyG83 deleted the fix/modal branch January 21, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyG83 BillyG83 BillyG83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y0moo @BillyG83