Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi NFT markers #4

Closed
kalwalt opened this issue May 7, 2020 · 6 comments
Closed

Multi NFT markers #4

kalwalt opened this issue May 7, 2020 · 6 comments
Labels
enhancement New feature or request nft

Comments

@kalwalt
Copy link
Member

kalwalt commented May 7, 2020

Hi @hiukim i'm testing your code that we discussed in the issue artoolkitx#95 in regards of your branch https://github.com/hiukim/jsartoolkit5/tree/fixnft Have you an example for testing the loadNFTMarkers ?

@kalwalt kalwalt added enhancement New feature or request nft labels May 7, 2020
@hiukim
Copy link

hiukim commented May 7, 2020

@kalwalt Unfortunately, I don't have a standalone example. But I suppose it you can first test it with the loadNFTMarker, which use loadNFTMarkers. The signature for loadNFTMarker is the same, so your existing code should work without making any changes.

I'm happy to help debug if you have found any errors.

@kalwalt
Copy link
Member Author

kalwalt commented May 7, 2020

@kalwalt Unfortunately, I don't have a standalone example. But I suppose it you can first test it with the loadNFTMarker, which use loadNFTMarkers. The signature for loadNFTMarker is the same, so your existing code should work without making any changes.

I'm happy to help debug if you have found any errors.

i already tested the basic example with the sphere, it seems to works well, i can't see any flaws, maybe is more fluid? I will try to setup a minimal example loading multi NFT. I can not say when but it's on my to do list. Have you seen also that i created a github team?

@hiukim
Copy link

hiukim commented May 7, 2020

@kalwalt nice. let me know if you encountered any error.

the webarkit team? I think I'm in already.

@kalwalt
Copy link
Member Author

kalwalt commented May 7, 2020

@kalwalt nice. let me know if you encountered any error.

the webarkit team? I think I'm in already.

Thank you, yes you are already in, just to know if the post i created is visible or not. It should be here https://github.com/orgs/webarkit/teams/webarkit/discussions/1

@hiukim
Copy link

hiukim commented May 7, 2020

@kalwalt Yes. I can see it now. :)

@ThorstenBux
Copy link
Member

I just merged all changes from @hiukim into our repo. This is probably breaking a whole lot of stuff but it is worth it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nft
Projects
None yet
Development

No branches or pull requests

3 participants