Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix OFAC filter #2459

Open
4 tasks
yurixander opened this issue Jul 26, 2024 · 2 comments
Open
4 tasks

[BUG] Fix OFAC filter #2459

yurixander opened this issue Jul 26, 2024 · 2 comments
Assignees
Labels
bug 🪲 Something isn't working on hold ⛔️ Indicates temporarily paused issues. tangle-dapp Tangle Staking dApp

Comments

@yurixander
Copy link
Member

yurixander commented Jul 26, 2024

The OFAC filter isn't working because the site used for geolocation is down.

Furthermore, the OFAC check logic can use some improvement(s), for example having a timeout if the request fails, and also saving the check result into local storage to prevent blocking the UI on every page load.

  • Use a separate, ideally reliable site.
  • Have a reasonable timeout for the check/request, to prevent blocking the UI if the request takes too long.
  • Save the result into local storage for subsequent page loads.
  • Ensure any errors from the OFAC filter are handled properly so that it does not break the site if the geolocation URL/service goes down in the future.

image

@yurixander yurixander added bug 🪲 Something isn't working tangle-dapp Tangle Staking dApp labels Jul 26, 2024
@yurixander yurixander assigned yurixander and unassigned yurixander Jul 26, 2024
@vutuanlinh2k2 vutuanlinh2k2 self-assigned this Jul 29, 2024
@drewstone
Copy link
Contributor

Don't worry about this for now, let's get all logic of the flows implemented and we'll revisit this before we go live.

@drewstone drewstone added the on hold ⛔️ Indicates temporarily paused issues. label Jul 29, 2024
@drewstone
Copy link
Contributor

For future use in a similar vein, we will want a generic address screening component. This would be useful to plugin different APIs that can screen an address for any compliance issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working on hold ⛔️ Indicates temporarily paused issues. tangle-dapp Tangle Staking dApp
Projects
Status: Not Started 🕧
Development

No branches or pull requests

3 participants