From 39a1f2ccaf9e1b10b016af056220a35d35e0a651 Mon Sep 17 00:00:00 2001 From: ojab Date: Tue, 8 Feb 2022 17:16:58 +0300 Subject: [PATCH] Don't start `ssh-agent` if it's already running This allows to run the action multiple times to add multiple keys without removing already added ones. --- dist/index.js | 27 ++++++++++++++++----------- index.js | 27 ++++++++++++++++----------- 2 files changed, 32 insertions(+), 22 deletions(-) diff --git a/dist/index.js b/dist/index.js index fe01c67..594d1a3 100644 --- a/dist/index.js +++ b/dist/index.js @@ -342,21 +342,26 @@ try { fs.appendFileSync(`${homeSsh}/known_hosts`, '\ngithub.com ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOMqqnkVzrm0SdG6UOoqKLsabgH5C9okWi0dh2l9GKJl\n'); fs.appendFileSync(`${homeSsh}/known_hosts`, '\ngithub.com ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==\n'); - console.log("Starting ssh-agent"); - const authSock = core.getInput('ssh-auth-sock'); const sshAgentArgs = (authSock && authSock.length > 0) ? ['-a', authSock] : []; - // Extract auth socket path and agent pid and set them as job variables - child_process.execFileSync(sshAgent, sshAgentArgs).toString().split("\n").forEach(function(line) { - const matches = /^(SSH_AUTH_SOCK|SSH_AGENT_PID)=(.*); export \1/.exec(line); - if (matches && matches.length > 0) { - // This will also set process.env accordingly, so changes take effect for this script - core.exportVariable(matches[1], matches[2]) - console.log(`${matches[1]}=${matches[2]}`); - } - }); + if (child_process.spawnSync(sshAdd, ['-l'], { env: { ...process.env, SSH_AUTH_SOCK: authSock || process.env.SSH_AUTH_SOCK } }).status === 0) { + console.log('ssh-agent is already running, not starting a new one') + } else { + console.log("Starting ssh-agent"); + + // Extract auth socket path and agent pid and set them as job variables + child_process.execFileSync(sshAgent, sshAgentArgs).toString().split("\n").forEach(function(line) { + const matches = /^(SSH_AUTH_SOCK|SSH_AGENT_PID)=(.*); export \1/.exec(line); + + if (matches && matches.length > 0) { + // This will also set process.env accordingly, so changes take effect for this script + core.exportVariable(matches[1], matches[2]) + console.log(`${matches[1]}=${matches[2]}`); + } + }); + } console.log("Adding private key(s) to agent"); diff --git a/index.js b/index.js index e08d46f..217be86 100644 --- a/index.js +++ b/index.js @@ -22,21 +22,26 @@ try { fs.appendFileSync(`${homeSsh}/known_hosts`, '\ngithub.com ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOMqqnkVzrm0SdG6UOoqKLsabgH5C9okWi0dh2l9GKJl\n'); fs.appendFileSync(`${homeSsh}/known_hosts`, '\ngithub.com ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==\n'); - console.log("Starting ssh-agent"); - const authSock = core.getInput('ssh-auth-sock'); const sshAgentArgs = (authSock && authSock.length > 0) ? ['-a', authSock] : []; - // Extract auth socket path and agent pid and set them as job variables - child_process.execFileSync(sshAgent, sshAgentArgs).toString().split("\n").forEach(function(line) { - const matches = /^(SSH_AUTH_SOCK|SSH_AGENT_PID)=(.*); export \1/.exec(line); - if (matches && matches.length > 0) { - // This will also set process.env accordingly, so changes take effect for this script - core.exportVariable(matches[1], matches[2]) - console.log(`${matches[1]}=${matches[2]}`); - } - }); + if (child_process.spawnSync(sshAdd, ['-l'], { env: { ...process.env, SSH_AUTH_SOCK: authSock || process.env.SSH_AUTH_SOCK } }).status === 0) { + console.log('ssh-agent is already running, not starting a new one') + } else { + console.log("Starting ssh-agent"); + + // Extract auth socket path and agent pid and set them as job variables + child_process.execFileSync(sshAgent, sshAgentArgs).toString().split("\n").forEach(function(line) { + const matches = /^(SSH_AUTH_SOCK|SSH_AGENT_PID)=(.*); export \1/.exec(line); + + if (matches && matches.length > 0) { + // This will also set process.env accordingly, so changes take effect for this script + core.exportVariable(matches[1], matches[2]) + console.log(`${matches[1]}=${matches[2]}`); + } + }); + } console.log("Adding private key(s) to agent");