Feat/issue 1155 enable attributes config in cognito #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge webiny master
Pavel910
requested changes
Jul 23, 2020
| const { | ||
| region = "us-east-1", | ||
| name, | ||
| tags = {}, | ||
| appClients = [], | ||
| allowSignup = false | ||
| allowSignup = false, | ||
| Schema |
There was a problem hiding this comment.
@Arun4you please make input keys for UsernameAttributes and Schema lower case, to be consistent with the existing components. usernameAttributes and schema.
There was a problem hiding this comment.
@Pavel910 Thank you for the feedback. I have committed the changes again. Please validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1155
Your solution
Passed the configured parameters to the AWS SDK.
How Has This Been Tested?
Deployed the Cognito resource from the local environment. The results are working as expected.
Screenshots (if relevant):
Screenshots are attached to the issue created.