Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show version of webiny #1195

Closed
bbarthel opened this issue Aug 21, 2020 · 15 comments · Fixed by #1321
Closed

Feature request: Show version of webiny #1195

bbarthel opened this issue Aug 21, 2020 · 15 comments · Fixed by #1321
Assignees
Labels
feature good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors. hacktoberfest

Comments

@bbarthel
Copy link

bbarthel commented Aug 21, 2020

Feature request: Show what version of Webiny that is published

Thoughts about location (/admin):

  • API Information
  • at the very bottom, e.g. webiny.com v4.9.2
@AlbionaHoti AlbionaHoti added this to the Webiny Hacktoberfest 2020 milestone Sep 24, 2020
@AlbionaHoti AlbionaHoti added the good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors. label Sep 28, 2020
@blenderskool
Copy link

blenderskool commented Oct 1, 2020

@AlbionaHoti I would like to work on this 🙂

Edit: Nevermind, I don't have an AWS account to work on this project ☹️

@AlbionaHoti
Copy link
Contributor

AlbionaHoti commented Oct 1, 2020

@AlbionaHoti I would like to work on this 🙂

Edit: Nevermind, I don't have an AWS account to work on this project ☹️

Hi @blenderskool, Welcome to Webiny :) Regarding the AWS account, you can read more from one of the FAQ. If you would like to contribute, you can follow up our Get Started YouTube videos to set up the requirements for starting with Webiny. 🚀

@parshnt
Copy link

parshnt commented Oct 3, 2020

Hello @AlbionaHoti @bbarthel

I would like to work on this issue :)

@AlbionaHoti
Copy link
Contributor

Hi @parshnt, You can continue with the issue. If you do have any question, please join our community slack, for it's easier to get in touch with the core team :)

@blenderskool thank you for your effort :)

@parshnt
Copy link

parshnt commented Oct 5, 2020

Sure @AlbionaHoti

I'm part of the community on Slack as well now :)

@aloks98
Copy link
Contributor

aloks98 commented Oct 18, 2020

@AlbionaHoti since there is no updates or PR by parshnt can I take up this issue?

@AlbionaHoti
Copy link
Contributor

Hey @aloks98, let's see if @parshnt has an update, if not, you can continue on the issue :)

@parshnt
Copy link

parshnt commented Oct 18, 2020

@AlbionaHoti

I'm halfway there, I've successfully added the current version to the bottom left on /admin but I'm a bit confused about API information part.

@AlbionaHoti
Copy link
Contributor

@parshnt please reach out if you have any questions on our slack community.

@AlbionaHoti
Copy link
Contributor

Hey @aloks98, if you are interested to contribute, you can continue with this issue, I'll assign it to you, just let me know!
Note that we have time up until 31st of October for the hacktoberfest approved issues 🚀

@aloks98
Copy link
Contributor

aloks98 commented Oct 26, 2020

@AlbionaHoti I have some questions about this.

  1. Where exactly I can find the version of webiny in the project? I found some version fields in package.json of some packages in api
  2. I also found the last released version from CHANGELOG.md. Should I use that?
  3. Where do I need to show the version of webiny? In the admin app/or the actual website that will be published?

@Ashu96
Copy link
Contributor

Ashu96 commented Oct 26, 2020

Hey @aloks98, thanks for asking these questions.

  1. We should first try to add a REACT_APP_WEBINY_VERSION variable to our bundling process. Something similar to this project-utils/bundling. As the CLI version will always be the same as other package versions, so it's safe to add it there.
  2. Inside this file you can import the version like this:
 const { version } = require("@webiny/project-utils/package.json");
  1. Ideally we want the version shown somewhere in the navigation, at the very bottom. For example,

image

Please let me know if you have more question 🙂

@aloks98
Copy link
Contributor

aloks98 commented Oct 26, 2020

Hey @Ashu96 I have made some changes!
Screenshot from 2020-10-26 22-51-26
One more thing, the process.env.REACT_APP_WEBINY_VERSION will be static? If it's static we have to change it with every version release.
If I may suggest, we can change the version in the package.json of the admin or webiny package (wherever the version is updated) and pull it from there into the bundling process?

@Ashu96
Copy link
Contributor

Ashu96 commented Oct 26, 2020

Nice work @aloks98

I don't get why process.env.REACT_APP_WEBINY_VERSION will be static if we're setting it to the package version we're importing like:

 const { version } = require("@webiny/project-utils/package.json");

as mentioned in the earlier comment.

ps: Please use community slack for faster response.

@aloks98
Copy link
Contributor

aloks98 commented Oct 26, 2020

Oh okay I missed that part xD I will change that now and make a PR :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors. hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants