Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Content Model validation message for name field #1303

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

jossperdomo
Copy link
Contributor

Related Issue

Closes #1124

Your solution

Added a new custom validator to check the name pattern in NewContentModelDialog component. It will show messages inside the dialog if the name starts with a number or it equals "id".

How Has This Been Tested?

For the name which starts with a number character:

  1. Open New Model dialog
  2. Enter "3D Asset" or any other name which starts with a number for the model name.
  3. Click Create button

For the name equals to "id":

  1. Open New Model dialog
  2. Enter "id" for the model name.
  3. Click Create button

Screenshots (if relevant):

Name starts with a number message:
error1
Name equals to "id":
error2

@jossperdomo
Copy link
Contributor Author

Hi! @AlbionaHoti sorry for the inconvenience, but it would be possible that while I'm waiting for the review of @Pavel910 you could add the label hacktoberfest-accepted, so that the verification time of hacktoberfest begins, thanks a lot :)

Copy link
Contributor

@Ashu96 Ashu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Good work @josselineperdomo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Model validation message not show in the dialog
2 participants