fix: correct behavior of plugins retrieval functions #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunozoric
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1308
Your solution
Changed the
byTypemethod to no longer acceptundefinedas a valid type. Added theallmethod toPluginsContaineras the correct way to retrieve all plugins.How Has This Been Tested?
I ran my changes against the existing tests, making sure that
plugins.test.js,modelFields.test.js,validators.test.js, andcontentModelToSDL.test.jspassed in particular.I also checked all uses of the
byTypemethod within the codebase to ensure that it was never being passed a value ofundefinedas a means for retrieving all plugins. As a result of this check, I updated thegetPluginsfunction inindex.tsto return all plugins when passed a value ofundefined. This is expected behavior based on the tests found inplugins.test.js.Screenshots (if relevant):
N/A