Support functions in schema security key. #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
CMS schema supports addition of
typeDefs
andresolvers
via plugins. However, we must also be able to add security rules via plugins. At this pointsecurity
only supported anobject
as its value, and as such it was interpreted too early for other plugins to be registered.Your solution
This PR adds the ability to assign a function to schema plugin
security
key, and it will be executed at runtime, when all plugins have already been registered, and so we'll be able to use our plugin system to addgraphql-shield
rules.How Has This Been Tested?
Manual testing.