Entities - store images as IDs, not plain objects #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
added a commit
that referenced
this pull request
Jul 17, 2019
This reverts commit 1168a56.
adrians5j
added a commit
that referenced
this pull request
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Previously, we would store images in entities as plain object:
{src,id,type,name}. Now we store them as refs, which enables users to change one image, and by doing that, immediately reflect this change on every place where the image was used.Some old/redundant files were deleted and also, the installation process / CMS export scripts (blocks/pages) were completely renewed.