Remove JSON response types for createFiles & uploadFiles fields
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
uploadFilesandcreateFileshadJSONtype for thedataresponse field.JSONis an anti-pattern in the GQL world, and also it would cause thecreateFilesfield to break when adatafield would be listed as a part of the GQL response.Your solution
Replace
JSONwith adequate fully-specified GQL types.How Has This Been Tested?
Manual testing - I tested the install process completely, just to make sure nothing breaks there as it is a critical piece of Webiny.
Screenshots (if relevant):
N/A