-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different DB drivers #623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors components and serverless template to work mostly with plugins. This enables us to customize apollo handler, apollo gateway, database drivers, etc. via plugins.
- @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected]
- @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected] - @webiny/[email protected]
adrians5j
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains many improvements with focus on support for different DB drivers (#575).
Along the way I also worked on Windows support, so you can setup our repo and deploy everything on Windows (closes #620).
To enable support for different drivers we had to push the usage of plugins a little bit further, here is an example of an apollo service configuration (see the
apolloService
key):A few things to note here:
@webiny/api-plugin-commodo-mongodb
. This way you can easily replace the driver plugin.@webiny/api-plugin-files-resolvers-mongodb
- this is a set of plugins for data resolvers that are using some DB native constructs, like Mongoaggregate
. We've implemented those resolvers via plugins, so when you replace a DB driver, you'll also have to provide a set of plugins to resolve the data using your database of choice.