Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete the S3 bucket, users must delete it manually #648

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Do not delete the S3 bucket, users must delete it manually #648

merged 1 commit into from
Dec 29, 2019

Conversation

adrians5j
Copy link
Member

Fixes #647.

Your solution

Removed the bucket deletion step.

How Has This Been Tested?

Manual testing.

Screenshots (if relevant):

image

@adrians5j adrians5j added the bug label Dec 23, 2019
@adrians5j adrians5j self-assigned this Dec 23, 2019
@adrians5j adrians5j changed the title fix: do not delete the S3 bucket, let users delete it on their own Do not delete the S3 bucket, let users delete it on their own Dec 23, 2019
@adrians5j adrians5j changed the title Do not delete the S3 bucket, let users delete it on their own Do not delete the S3 bucket, users must delete it manually Dec 23, 2019
@adrians5j adrians5j merged commit 8d5d990 into webiny:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverless-files: on "webiny remove-api", do not delete the S3 bucket
2 participants