-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PB Element plugin errors during render #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few change requests :)
Can you also attach an image to the PR of what an error looks like when rendered? Thanks! |
Here we go, there's an image now |
Also, I'll remove the commented lines currently present in the code if this version of the PR is ok. Those lines help me test it out 😄 |
@Fsalker this looks ok, we can tweak minor things later on. One last thing: replace the |
alright, here we go. everything should be k now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this one and I'll give it another test before publishing.
Related Issue
#686
Your solution
Wrapped the two
Element.tsx
components inside Error Boundaries.How Has This Been Tested?
The
Render
Element
was tested by opening up the Pages. Here we clearly see anElement
component which I've tested by intentionally throwing an error inside the Error Boundary.