Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error message of deploy apps to be more descriptive #732

Merged
merged 9 commits into from
Feb 29, 2020
Merged

Changed error message of deploy apps to be more descriptive #732

merged 9 commits into from
Feb 29, 2020

Conversation

ahmad-reza619
Copy link
Contributor

Related Issue

close #685

Your solution

I have changed the error message of webiny deploy-apps to be more descriptive so that it's a little bit more descriptive

How Has This Been Tested?

  1. run webiny deploy-apps --env=dev with prerequisites of not having dev environment .env.json files in apps
  2. there will be an error saying
Environment {name of environment} is missing {app path}/.env.json file.
Have you deployed the corresponding API environment?
To deploy the API, run "webiny deploy-api --env=dev."

Screenshots (if relevant):

@ahmad-reza619 ahmad-reza619 changed the title Issue 685 Changed error message of deploy apps to be more descriptive Feb 29, 2020
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I've added some minor change requests :)

packages/cli/sls/deploy.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/cli/sls/deploy.js Outdated Show resolved Hide resolved
@Pavel910
Copy link
Collaborator

Looks good! Thank you for your time and congratulations on your first PR! 🎉

@Pavel910 Pavel910 merged commit f696517 into webiny:master Feb 29, 2020
@ahmad-reza619
Copy link
Contributor Author

Looks good! Thank you for your time and congratulations on your first PR! 🎉

Sweet! Thank you too for all of your help 😄 glad i can be help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messaging on apps deploy.
3 participants