Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N Service Plugins - Improve Error Messaging #748

Closed
adrians5j opened this issue Mar 10, 2020 · 2 comments
Closed

I18N Service Plugins - Improve Error Messaging #748

adrians5j opened this issue Mar 10, 2020 · 2 comments
Labels
feature good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors.

Comments

@adrians5j
Copy link
Member

This is:

  • Feature request

Detailed Description

Currently, if a user forgets to pass the I18N_API_URL into the serverless component (serverless.yml), the whole service would not work at all.

image

And if you open the CloudWatch log, you can see the following error:
image

Possible Solution

This error probably won't mean a lot to the user, so let's make it a bit more friendly.

Let's check the passed env variable here: packages/api-i18n/src/plugins/service.ts:32.

If it doesn't exist, or it's not a valid URL, we should throw an error message like

I18N_API_URL env variable is not a valid URL. Make sure it's specified in the service configuration..

This is just a quick example. Of course, you are allowed to use your imagination / be creative 😃

@adrians5j adrians5j added feature good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors. labels Mar 10, 2020
@maxmmorz
Copy link
Contributor

May I start working on this issue?

@adrians5j
Copy link
Member Author

Sure, go for it!

If you need any assistance, just let us know here, or via gitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue An issue that is not too complicated to resolve, and it's an ideal issue for new contributors.
Projects
None yet
Development

No branches or pull requests

2 participants