Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated React URL links #752

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Updated React URL links #752

merged 1 commit into from
Mar 13, 2020

Conversation

visshaljagtap
Copy link
Contributor

Updated React URL links

@Fsalker
Copy link
Contributor

Fsalker commented Mar 13, 2020

Hey visshaljagtap, I think this is a cool update. Even though the improvement is marginal, reactjs.org is the actual domain we're landing on and the one we should hit when clicking those documentation anchors.

Let's see what the other guys say about it. 😄

@visshaljagtap
Copy link
Contributor Author

visshaljagtap commented Mar 13, 2020 •
edited
Loading

Yeah @Fsalker but due to this we can avoid unnecessary redirection. React team also have updated their old domain url with latest one!

Pavel910
Pavel910 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time @visshaljagtap! As a heads-up, we're already working on a much more straightforward and dev-friendly way to setup the apps, and we'll completely remove CRA/react-scripts from our workflow.

If you care to review the idea, take a look at this RFC. Feel free to leave comments and suggest improvements!

@Pavel910 Pavel910 merged commit ae585be into webiny:master Mar 13, 2020
@visshaljagtap
Copy link
Contributor Author

Thats Nice! @Pavel910 Surely I will have a look on same!

@brunozoric brunozoric mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavel910 Pavel910 Pavel910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visshaljagtap @Fsalker @Pavel910