Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LSTMClassifier #67

Open
chschroeder opened this issue Sep 29, 2024 · 0 comments
Open

Add LSTMClassifier #67

chschroeder opened this issue Sep 29, 2024 · 0 comments
Labels
feature request New feature request help wanted Extra attention is needed

Comments

@chschroeder
Copy link
Contributor

chschroeder commented Sep 29, 2024

Feature description

Add an LSTM Pytorch model and and LSTMClassifier.

Edit:
I am just a few weeks away from a 2.0.0-alpha release. Therefore, starting branch would be the dev branch.

Points for this task that I can see:

  • Use the Pytorch LSTM implementation: https://pytorch.org/docs/stable/generated/torch.nn.LSTM.html
  • small_text/integrations/pytorch/classifiers/kimcnn.py:
    • In the best case we would generalize this, to a PytorchClassifier (or TorchClassifier?).
    • The EmbeddingMixin is the most significant difference. We have to see if this part can be unified.
  • The unit / integration tests would mirror the KimCNNClassifier tests

Motivation

This request has reached me via an e-mail. Also, LSTMs have been on my todo list for quite a while.

Additional comments

  • Module-wise, this belongs in the pytorch integration packages.
  • I won't have time for this anytime soon. Contributions are welcome.
@chschroeder chschroeder added feature request New feature request help wanted Extra attention is needed labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant