Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall module - Activate at boot #255

Closed
albertovincenzi opened this issue Sep 30, 2015 · 8 comments
Closed

Firewall module - Activate at boot #255

albertovincenzi opened this issue Sep 30, 2015 · 8 comments

Comments

@albertovincenzi
Copy link

If in firewall module I set "activate at boot" to yes, once I save the setting, the flag is reverted to "no".
With the default theme I don't have the same issue

@iliajie
Copy link
Collaborator

iliajie commented Sep 30, 2015

Confirmed. This bug is happening when in settings Enable customized checkboxes and radio buttons is enabled (default).

I will try to figure out the source of the problem and fix it by next release.

Thanks!

@iliajie
Copy link
Collaborator

iliajie commented Sep 30, 2015

It is happening in all modules with bootup.cgi form, which is technically incorrectly build, having no form data on the inside. It works for some funky reason with default checkboxes but not custom.

Add the following script in theme's extenison (JS) to fix this issue across all modules:

if (t___wi.location != t__wi_p.location) {
     $('form[action="bootup.cgi"]').on('submit', function () {
          $(this).append('<input type="hidden" name="boot" value="' + $('input[name="boot"]:checked').val() + '">')
     });
}

In the future release I will add this to the package.

Thanks for reporting on this wild bug!

@iliajie iliajie closed this as completed Sep 30, 2015
@albertovincenzi
Copy link
Author

I'm having the same problem with last version of the theme.

@iliajie
Copy link
Collaborator

iliajie commented Jun 20, 2016

I was testing it with 18.03 - it was working. Did you clear cache after upgrading the theme?

@iliajie
Copy link
Collaborator

iliajie commented Jun 20, 2016

What version of the theme are you using?

@albertovincenzi
Copy link
Author

17.84 on debian wheezy. I thought that was updated because didn't mentioned about a new version of the theme, then I set auto update check to on (default was off). Even if I set to auto update, I don't get the new version. Click on force update didn't solved.
I manually done it: downloaded 18.03 solved the problem but still don't notice the 18.04 update by autoupdate feature.

@iliajie
Copy link
Collaborator

iliajie commented Jun 20, 2016

Update notice will work with the next Webmin release.

@iliajie
Copy link
Collaborator

iliajie commented Jun 21, 2016

Or apply this fix:

webmin/webmin#393 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants