Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Doesn't work in Microsoft browsers after 18.49 update #782

Closed
Sopor opened this issue May 18, 2017 · 17 comments
Closed

Theme: Doesn't work in Microsoft browsers after 18.49 update #782

Sopor opened this issue May 18, 2017 · 17 comments
Labels

Comments

@Sopor
Copy link
Contributor

Sopor commented May 18, 2017

When i want to change permission this window will popup but as you can see it is not the whole window. It happens if i do it 15 items from the top. I can't even scroll up. The only way to show the complete window is to use the auto scroll (press the wheel button and move the mouse). (Firefox)

picpick-2017 05 18-21 55 11

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

It seems to be the same for, permissions, ownerships and attributes and you need to have many files/folders so it will make the web browser to show its scrollbar to reproduce it.
It seems to jump to the first place where you can type but i do want to see the whole window and even the title of the window.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

What is your browser, screen resolution and OS?

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

Firefox 53.0.2, 1920x1080 and Windows 8.1.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

What if you try Chrome, do you get the same result?

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

It is working in Chrome.
If i try IE the whole theme won't work but you don't support IE, or do you?

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

I do, it should work in IE but not very well. Edge works much better. Which IE version is that?

About combination of Firefox and Windows 8 - I have encountered mysterious behaviour with my other projects. Things that worked in Firefox in Windows 7 and 10 didn't work on 8.

Did this happen before in previous versions of the theme? Why are you reporting it after the release?

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

I do, it should work in IE but not very well. Edge works much better. Which IE version is that?

IE 11

About combination of Firefox and Windows 8 - I have encountered mysterious behaviour with my other projects. Things that worked in Firefox in Windows 7 and 10 didn't work on 8.

I'm running 8.1 not 8 😏

Did this happen before in previous versions of the theme? Why are you reporting it after the release?

I haven't played around so much with the file manager. I started to use your theme for some weeks ago and it take some time to test everything. I'm not using the file manager so much either but now when i was trying to find those new strings i wanted to translate i manage to find this too.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

The funny thing and actually very frustrating, that Microsoft thinks that they can build software their own, all-wrong way, hurting developers all over the World, including development process in general. 😢

Yes, after I did optimizations, Microsoft Internet Explorer and Microsoft Edge don't work correctly. They handle load event in absolutely inappropriate way.

I will make a fix tomorrow.

I have made the theme properly get updated from 18.49 to 18.49-1 so there should be no problem to release this kind of version.

I think, the best thing to do is to generate a message for Internet Explorer users, asking them to switch away, to at least Edge or other decent browser, like Chrome or Firefox at least. It's easy to do and good for all.

Theme is extremely complex by its nature and I can not combine creativity and amazing features that it brings, with non compliant browsers.

@Sopor- Thank you for reporting.

@iliajie iliajie changed the title File manager - when changing permissions the window will not show up fully Theme: Doesn't work in Microsoft browsers after 18.49 update May 18, 2017
@iliajie iliajie added the bug label May 18, 2017
@iliajie
Copy link
Collaborator

iliajie commented May 19, 2017

Hi,

I have made a fix in 18.49-1, that supports Microsoft browsers now. Could you please update and try.

Microsoft Internet Explorer 11 and all Edge browsers should work from now on.

Make sure that you manually clear browser's cache to make sure that the old files are overwritten.

About your initial request, this is how my Firefox on Windows 10 looks like:

screenshot from 2017-05-19 12-23-02

Should I install Windows 8 to my box to try to reproduce your issue?

@iliajie iliajie closed this as completed May 19, 2017
@Sopor
Copy link
Contributor Author

Sopor commented May 19, 2017

In the above picture i see why it is working for you. You need to have more folder or files on your screen. You need to have more than one screen and then you need to scroll down and then change permissions on a file or folder that is not on the first screen.

@Sopor
Copy link
Contributor Author

Sopor commented May 19, 2017

Microsoft Internet Explorer 11 and all Edge browsers should work from now on.

The Dashboard seems to work in IE 11 but not the file manager. It is also very hard to change to Dashboard when the file manager has started to flash. It won't obey my mouse clicks. And yes, i have empty the Temporary internet files

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

I had flashy File Manager in IE11 before the fix I provided above. Afterwards it was all working.

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

It's flickering again. Seem like something needs to be fixed again.

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

I'll take a look.

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

..and modal on many files is off, on Linux as well. I'll take a look. Thanks.

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

Flashing in IE seems to be fixed. However, before I made any changes to the code, after I opened console in IE, and run File Manager again from the left menu - the flashing disappeared. 🪲

Let's see how it will work for you after update.

Firefox is doing very strange thing with the modal, absolutely illogical from my point of view. Do you have a clue why this could be happening?

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

Flashing is back in IE11, unless I open console at least once. This is so buggy. I'm willing to fix it, bug as of what I described above, I don't see how it's possible to fix. It more looks like IE bug as it works in all other browsers, including Edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants