Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded psalm asserts #146

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Remove unneeded psalm asserts #146

merged 1 commit into from
Nov 5, 2019

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 4, 2019

Closes #145

@BackEndTea
Copy link
Collaborator

We validate the asserts with the files in the tests/static-analysis folder. Could you please remove the files relevant to these assertions

@ruudk
Copy link
Contributor Author

ruudk commented Nov 4, 2019

@BackEndTea Done!

@BackEndTea
Copy link
Collaborator

The travis failure seems unrelated. However i'm unable to merge when travis fails 😅. Could you push to this branch again in order to trigger travis one more time?

@ruudk
Copy link
Contributor Author

ruudk commented Nov 4, 2019

Done :)

@BackEndTea
Copy link
Collaborator

Thank you, there is a few small things i'd like to do before releasing this, so expect 1.6.0 to be released tomorrow.

@BackEndTea BackEndTea merged commit 0aaeb65 into webmozarts:master Nov 5, 2019
@ruudk
Copy link
Contributor Author

ruudk commented Nov 5, 2019

@BackEndTea Thanks 💙

@ruudk ruudk deleted the patch-2 branch November 5, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove psalm-assert for 'side effect' assertions
2 participants