fix(index): `tapable` deprecation warnings (`webpack >= v4.0.0`) #81

ryanclark · 2018-03-08T19:19:56Z

`Notable Changes`

Adds support for webpack >= 4.

michael-ciniawsky · 2018-03-08T21:56:35Z

package.json

-    "webpack": "^3.3.0",
-    "webpack-defaults": "^1.5.0"
+    "webpack": "^3.10.0",
+    "webpack-defaults": "^2.0.0-rc.2"


Please do this in a separate PR, since webpack-defaults >= v2.0.0 requires node >= v6.0.0 and applying it is a semver major

michael-ciniawsky · 2018-03-08T21:58:58Z

src/index.js

@@ -8,6 +8,58 @@ function getDefault(actualValue, defaultValue) {
  return actualValue !== void 0 ? actualValue : defaultValue;
 }

+const NAMESPACE = 'BabelMinifyPlugin';


Move this into the ctor of BabelMinifyPlugin

class BabelMinifyPlugin { constructor () { this.plugin = { name: 'BabelMinifyPlugin' } } }

michael-ciniawsky · 2018-03-08T22:00:00Z

src/index.js

-                compilation.assets[file] = asset.__babelminified;
-                return;
-              }
+    const isWebpack4 = !!compiler.hooks;


Since this check is only used once if (compiler.hooks) is sufficient

michael-ciniawsky · 2018-03-08T22:01:34Z

src/index.js

-              let input;
-              let inputSourceMap;
+    if (isWebpack4) {
+      compiler.hooks


if (compiler.hooks) const { plugin } = this const { compilation } = compiler.hooks compilation.tap(plugin, ...) ... }

michael-ciniawsky · 2018-03-08T22:07:41Z

src/index.js

+    if (isWebpack4) {
+      compiler.hooks
+        .compilation
+        .tap(NAMESPACE, (compilation) => {


The compilation callbacks could also be extracted into a {Function}

function buildModuleFn () {} function optimizeChunkAssetsFn () {} function compilationFn (compilation) { if (compilation.hooks) { const { plugin } = this const { buildModule, optimizeChunksAssets } = compilation.hooks buildModule.tap(plugin, buildModuleFn) optiimizeChunksAssets.tap(plugin, optimizeChunkAssetsFn) } else { compilation.plugin('build-module', buildModuleFn) compilation.plugin('optimize-chunk-assets', optimizeChunkAssetsFn) } } if (compiler.hooks) { ... compilation.tap(plugin, compilationFn) } else { compiler.plugin('compilation', compilationFn) }

michael-ciniawsky · 2018-03-08T22:30:11Z

package.json

@@ -29,10 +29,11 @@
    "travis:coverage": "npm run test:coverage -- --runInBand",
    "travis:lint": "npm run lint && npm run security",
    "travis:test": "npm run test -- --runInBand",
-    "webpack-defaults": "webpack-defaults"
+    "webpack-defaults": "webpack-defaults",


- "webpack-defaults": "webpack-defaults",

michael-ciniawsky · 2018-03-08T22:53:53Z

package.json

@@ -28,9 +28,7 @@
    "test:watch": "jest --watch",
    "travis:coverage": "npm run test:coverage -- --runInBand",
    "travis:lint": "npm run lint && npm run security",
-    "travis:test": "npm run test -- --runInBand",
-    "webpack-defaults": "webpack-defaults",
-    "defaults": "webpack-defaults"


"defaults": "webpack-defaults" should stay :P

michael-ciniawsky

👍

michael-ciniawsky · 2018-03-11T23:43:23Z

src/index.js

+function compilationFn(useHooks, compilation) {
+  const { options, plugin } = this;
+
+  if (useHooks) {


useHooks => if (compilation.hooks)

alexander-akait

Looks good!

michael-ciniawsky · 2018-03-16T14:29:51Z

Release blocked by https://status.npmjs.org/incidents/gbk5bjx1169j 😞

ooflorent · 2018-03-16T14:33:23Z

src/index.js

-            }
-          });
+    if (compiler.hooks) {
+      const { compilation } = compiler.hooks;


In webpack we banned this pattern because it prevents searching for hooks.*.

hmm... 🤔 debatable imho :P, personally always in favor of compacter code and here searching for the hookName (e.g compilation) instead then. A search for hooks*, one still gets where the hooks got destructured. Maybe destructuring is more confusing then helpful within larger parts of the webpack code base e.g Parser or the like ¯_(ツ)_/¯. Or did you mean something entirely different, with can break here ? 🙃

Anyways if there is general consensus on avoiding to destructure .hooks fine with either... :)

michael-ciniawsky · 2018-03-19T19:57:05Z

Released in v0.3.1 🎉 Thx

ryanclark force-pushed the webpack-4 branch 2 times, most recently from e255f0a to 1f278a7 Compare March 8, 2018 21:11

michael-ciniawsky changed the title ~~feat: add webpack 4 support~~ fix(index): tapable deprecation warnings (webpack >= v4.0.0) Mar 8, 2018

michael-ciniawsky suggested changes Mar 8, 2018

View reviewed changes

michael-ciniawsky added this to the v0.3.1 milestone Mar 8, 2018

michael-ciniawsky added type: Bug severity: 4 (inconvenient) priority: 3 (required) pr_action: Review semver: Patch status: Pending labels Mar 8, 2018

michael-ciniawsky requested review from alexander-akait and joshwiens March 8, 2018 22:11

ryanclark force-pushed the webpack-4 branch 2 times, most recently from 527db3e to 3ab66a2 Compare March 8, 2018 22:37

michael-ciniawsky reviewed Mar 8, 2018

View reviewed changes

ryanclark force-pushed the webpack-4 branch from 3ab66a2 to 4bbf479 Compare March 8, 2018 22:45

michael-ciniawsky reviewed Mar 8, 2018

View reviewed changes

michael-ciniawsky approved these changes Mar 8, 2018

View reviewed changes

ryanclark force-pushed the webpack-4 branch from 627efeb to 3c0e62e Compare March 8, 2018 22:56

feat: add webpack 4 support

f6101b8

ryanclark force-pushed the webpack-4 branch from 3c0e62e to f6101b8 Compare March 9, 2018 22:22

michael-ciniawsky reviewed Mar 11, 2018

View reviewed changes

chore(index): remove unneeded hook check

4b65e0e

michael-ciniawsky closed this Mar 16, 2018

michael-ciniawsky reopened this Mar 16, 2018

alexander-akait approved these changes Mar 16, 2018

View reviewed changes

michael-ciniawsky added status: Approved and removed pr_action: Review priority: 3 (required) labels Mar 16, 2018

michael-ciniawsky removed severity: 4 (inconvenient) status: Pending labels Mar 16, 2018

michael-ciniawsky merged commit 5c41e40 into webpack-contrib:master Mar 16, 2018

ooflorent reviewed Mar 16, 2018

View reviewed changes

michael-ciniawsky removed this from the v0.3.1 milestone Mar 19, 2018

ryanclark deleted the webpack-4 branch March 19, 2018 22:13

This was referenced Mar 20, 2018

Bump babel-minify-webpack-plugin from 0.3.0 to 0.3.1 mileszim/tempmail.js#37

Open

Bump babel-minify-webpack-plugin from 0.3.0 to 0.3.1 neinteractiveliterature/intercode#714

Merged

dependencies bot mentioned this pull request Mar 20, 2018

Update babel-minify-webpack-plugin in /packages/oc-template-react-compiler from 0.3.0 to 0.3.1 opencomponents/oc-template-react#173

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(index): `tapable` deprecation warnings (`webpack >= v4.0.0`) #81

fix(index): `tapable` deprecation warnings (`webpack >= v4.0.0`) #81

ryanclark commented Mar 8, 2018 •

edited by michael-ciniawsky

Loading

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky Mar 8, 2018

michael-ciniawsky left a comment

michael-ciniawsky Mar 11, 2018

alexander-akait left a comment

michael-ciniawsky commented Mar 16, 2018 •

edited

Loading

ooflorent Mar 16, 2018

michael-ciniawsky Mar 16, 2018

michael-ciniawsky commented Mar 19, 2018

fix(index): tapable deprecation warnings (webpack >= v4.0.0) #81

fix(index): tapable deprecation warnings (webpack >= v4.0.0) #81

Conversation

ryanclark commented Mar 8, 2018 • edited by michael-ciniawsky Loading

Notable Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

michael-ciniawsky commented Mar 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michael-ciniawsky commented Mar 19, 2018

fix(index): `tapable` deprecation warnings (`webpack >= v4.0.0`) #81

fix(index): `tapable` deprecation warnings (`webpack >= v4.0.0`) #81

ryanclark commented Mar 8, 2018 •

edited by michael-ciniawsky

Loading

`Notable Changes`

michael-ciniawsky commented Mar 16, 2018 •

edited

Loading