Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Does not support require.ensure error callback added in Webpack 2.4 #45

Open
jharris4 opened this issue Apr 15, 2017 · 2 comments
Open

Comments

@jharris4
Copy link

Webpack 2.4 added support for error callbacks as a 2nd argument to require.ensure:

webpack/webpack#4069

This is not supported by the bundle-loader, but there is a forked version of the loader that does support the require.ensure error callback: https://github.com/jharris4/split-chunk-loader

I'd consider making a PR to merge the changes from split-chunk-loader into bundle-loader, but not sure of the best way to handle the fact that webpack >= 2.4 is required for that to work. Maybe adding a peerDependency would do the trick?

@michael-ciniawsky
Copy link
Member

If you have the time and have something in mind already please feel free to send PR, it would be apprectiated 😛
In regrads to necessity of webpack >= v2.4.0, a peerDependency would be fine imho, but I need to discuss && verify that. In any case we will find a solution to deal with it, so your PR won't be wasted :)

@jharris4
Copy link
Author

PR created: #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants