-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 6 (for Webpack 4) does not work on Node 18+ #364
Comments
Pinging @TheLarkInn as you merged webpack/webpack#17628 |
before the precompile execute this command |
Yes this kind of fixes the issue, but the intend for webpack/webpack#17628 is to avoid this and allow Webpack 4 to run on Node 18 without those changes. I think this could be fixed by requiring Webpack 4.47.0 and using |
i look forward to not needing to run the export. |
I can confirm that applying this patch over the 6.1.1 version works with Node 18: Edit: removed patch, see below I am not sure how I can submit a PR for this, or if the maintainers can easily make a new v6 release. I updated the peer deps to require the latest Webpack 4 version, as this is the one exporting |
I forked the repository and added a commit that makes the plugin work with Webpack 4 and Node 18+ (tested with Node 18 and Node 20 on Mastodon, see mastodon/mastodon#26830). You can find the related changes here: renchap@a98a929 The This is published on NPM as It would be very welcome for a maintainer of this package to use this patch and release an official 6.1.2 version, so people stuck on Webpack 4 can upgrade to a supported Node version. |
We'll do a patch release. |
Thanks! Any estimate for when this will happen? |
Fixed #373, release will be soon |
Please try https://github.com/webpack-contrib/compression-webpack-plugin/releases/tag/v6.1.2, sorry for delay |
Bug report
When running Webpack 4 with the latest version of this plugin on Node 18 (thanks to the new Webpack 4 version), it fails with this error:
Actual Behavior
Build fails with the error above
Expected Behavior
The build should complete without error on Node 18
How Do We Reproduce?
This can be reproduced on Mastodon with this PR: mastodon/mastodon#26830 (look at the failed github actions)
Please paste the results of
npx webpack-cli info
here, and mention other relevant informationWebpack version 4.47.0
compression-webpack-plugin
version 6.1.1 (latest version compatible with Webpack 4)The text was updated successfully, but these errors were encountered: