Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with ES modules syntax and hash in url function #1001

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

webpack-contrib/mini-css-extract-plugin#469

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1001 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   98.35%   98.38%   +0.03%     
==========================================
  Files          10       10              
  Lines         425      434       +9     
  Branches      126      131       +5     
==========================================
+ Hits          418      427       +9     
  Misses          7        7
Impacted Files Coverage Δ
src/utils.js 99.37% <100%> (+0.01%) ⬆️
src/runtime/getUrl.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21ab00...6dcd94e. Read the comment docs.

@alexander-akait alexander-akait force-pushed the fix-compatibility-with-es-modules-syntax-and-hash-in-url branch from 722bb28 to a646ca1 Compare December 2, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants