Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not crash with 'false' aliases #1292

Merged
merged 6 commits into from
Apr 19, 2021
Merged

fix: do not crash with 'false' aliases #1292

merged 6 commits into from
Apr 19, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1291

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1292 (dfabb21) into master (2388439) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
+ Coverage   97.72%   98.22%   +0.49%     
==========================================
  Files          11       11              
  Lines         835      844       +9     
  Branches      279      283       +4     
==========================================
+ Hits          816      829      +13     
+ Misses         16       12       -4     
  Partials        3        3              
Impacted Files Coverage Δ
src/plugins/postcss-icss-parser.js 100.00% <100.00%> (ø)
src/plugins/postcss-import-parser.js 100.00% <100.00%> (ø)
src/plugins/postcss-url-parser.js 97.63% <100.00%> (+0.02%) ⬆️
src/utils.js 97.15% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2388439...dfabb21. Read the comment docs.

@alexander-akait alexander-akait merged commit e913cb1 into master Apr 19, 2021
@alexander-akait alexander-akait deleted the issue-1291 branch April 19, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using webpack alias false breaks build
1 participant