Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use template literal when it possible to prevent `Maximum call … #1525

Merged

Conversation

alexander-akait
Copy link
Member

…stack size exceeded`

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #771

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (0a2a596) 96.76% compared to head (1b55942) 96.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
+ Coverage   96.76%   96.87%   +0.10%     
==========================================
  Files          10       10              
  Lines        1145     1185      +40     
  Branches      421      456      +35     
==========================================
+ Hits         1108     1148      +40     
  Misses         28       28              
  Partials        9        9              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 95.06% <100.00%> (+0.25%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sgarfinkel
sgarfinkel previously approved these changes May 27, 2023
Copy link

@sgarfinkel sgarfinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgarfinkel
Copy link

Could possibly infer this from browserslist?

@alexander-akait
Copy link
Member Author

@sgarfinkel We already do it on webpack side level https://webpack.js.org/configuration/target/, so if you have browserslist we will use it

@alexander-akait
Copy link
Member Author

Infer a platform and the ES-features from a browserslist-config (default if browserslist config is available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"RangeError: Maximum call stack size exceeded" when compiling a file with many requires
2 participants