-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0.0] getLocalIdent validation #862
Comments
@gpoitch what you expected from |
I expect it to fallback to using getLocalIdent: isProduction ? function(){ /*...*/ } : undefined |
@gpoitch maybe we can accept |
@evilebottnawi yes, that'd be nice, as it worked in 1.x. Otherwise that is a tiny breaking change |
@gpoitch let's mark it as bug and fix in |
previous we don't have schema options and tests so i can lose something, sorry |
Expected Behavior
Previously, if
getLocalIdent
returned a falsey value, css-loader would fallback to usinglocalIdentName
Actual Behavior
css-loader throws an error:
Code
How Do We Reproduce?
Run tests with those loader options
The text was updated successfully, but these errors were encountered: