Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better export escaped locals #920

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Better export locals for escaping selectors

Breaking Changes

In theory yes becase it is change css output for classes and ids but previously implementation was wrong so it is bugfix

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #920 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   99.25%   99.24%   -0.02%     
==========================================
  Files          10       10              
  Lines         401      395       -6     
  Branches      119      119              
==========================================
- Hits          398      392       -6     
  Misses          3        3
Impacted Files Coverage Δ
src/utils.js 97.29% <100%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe10758...135d780. Read the comment docs.

@alexander-akait alexander-akait merged commit d3a0a3c into master Apr 10, 2019
@alexander-akait alexander-akait deleted the refactor-better-export-escaped-locals branch April 10, 2019 15:43
options
);

return normalizeIdentifier(hash);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line makes the replacing the / in path to - no longer working.
Is that on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants