Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modules options now accepts object config #937

Merged
merged 1 commit into from
May 28, 2019

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 28, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Move all CSS modules options in modules option.

Breaking Changes

Yes

BREAKING CHANGES:

  • localIdentName option was removed in favor modules.localIdentName option
  • context option was remove in favor modules.context option
  • hashPrefix option was removed in favor modules.hashPrefix option
  • getLocalIdent option was removed in favor modules.getLocalIdent option
  • localIdentRegExp option was removed in favor modules.localIdentRegExp option

Additional Info

No

@alexander-akait alexander-akait force-pushed the feat-modules-accept-object-config branch from 7545541 to 984fff6 Compare May 28, 2019 15:47
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #937 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   99.26%   99.27%   +<.01%     
==========================================
  Files          10       10              
  Lines         408      411       +3     
  Branches      121      121              
==========================================
+ Hits          405      408       +3     
  Misses          3        3
Impacted Files Coverage Δ
src/utils.js 99.23% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ff645...6231f35. Read the comment docs.

BREAKING CHANGE:
- `localIdentName` option was removed in favor `modules.localIdentName` option
- `context` option was remove in favor `modules.context` option
- `hashPrefix` option was removed in favor `modules.hashPrefix` option
- `getLocalIdent` option was removed in favor `modules.getLocalIdent` option
- `localIdentRegExp` option was removed in favor `modules.localIdentRegExp` option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant