Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(index): source code indentation #299

Merged
merged 1 commit into from
Jan 26, 2018
Merged

fix(index): source code indentation #299

merged 1 commit into from
Jan 26, 2018

Conversation

lydell
Copy link
Contributor

@lydell lydell commented Jan 26, 2018

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
none needed

If relevant, did you update the README?
not relevant

Summary
Removed trailing whitespace, fixed indentation (some lines had spaces instead of tabs like all other lines).
be51e32#r27136994

Does this PR introduce a breaking change?
nope

lydell referenced this pull request Jan 26, 2018
@michael-ciniawsky
refactor: remove comments from bundle source code
be51e32
@michael-ciniawsky
Copy link
Member

Could you check if other files like url.js && useable.js are also out-of-whack please ?

@michael-ciniawsky michael-ciniawsky changed the title chore(index): Fix whitespace chore(index): fix source code indentation whitespace Jan 26, 2018
@lydell
Copy link
Contributor Author

lydell commented Jan 26, 2018

I already did ;) I didn't spot anything obvious.

@lydell
Copy link
Contributor Author

lydell commented Jan 26, 2018

Good thing that you use Prettier in the next branch ;)

@michael-ciniawsky michael-ciniawsky changed the title chore(index): fix source code indentation whitespace fix(index): source code indentation Jan 26, 2018
michael-ciniawsky
michael-ciniawsky approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@michael-ciniawsky michael-ciniawsky merged commit b4642e7 into webpack-contrib:master Jan 26, 2018
@lydell lydell deleted the fix-whitespace branch January 26, 2018 21:20
This was referenced Jan 27, 2018
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 16, 2019
Closed
This was referenced Oct 4, 2019
Merged
Merged
Merged
Merged
This was referenced Nov 7, 2019
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
This was referenced Feb 17, 2020
Merged
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Merged
This was referenced Apr 1, 2020
Open
Open
Open
Open
This was referenced Apr 23, 2020
Open
Open
Open
Open
Closed
This was referenced May 4, 2020
Open
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jun 20, 2024
Open
@KrisPeachyKen KrisPeachyKen mentioned this pull request Jul 30, 2024
Open
@superadmiral superadmiral mentioned this pull request Jul 30, 2024
Open
@YinghanFeng YinghanFeng mentioned this pull request Aug 2, 2024
Open
@go-benchmark1 go-benchmark1 mentioned this pull request Aug 16, 2024
Open
@lucasaugustodeveloper lucasaugustodeveloper mentioned this pull request Sep 8, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 26, 2024
Open
@anmipa anmipa mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Assignees
No one assigned
Labels
semver: Patch status: Approved type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lydell @michael-ciniawsky