Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tag type configuration #316

Merged
merged 2 commits into from
Apr 17, 2018
Merged

feat: enable tag type configuration #316

merged 2 commits into from
Apr 17, 2018

Conversation

Nouzbe
Copy link
Contributor

@Nouzbe Nouzbe commented Apr 17, 2018

What kind of change does this PR introduce?

Small feature

Did you add tests for your changes?
Yes.

If relevant, did you update the README?
No.

Summary

This lets projects using style-loader define the type of the style or link tags in the attrs option of the loader, along with other tag attributes. See style-loader/issues/315

Does this PR introduce a breaking change?

No.

Other information

@jsf-clabot
Copy link

jsf-clabot commented Apr 17, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files           4        4           
  Lines          64       64           
  Branches       21       21           
=======================================
  Hits           63       63           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3e6b5...752223b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants