Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noop in environment without DOM API #597

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #595

Breaking Changes

No

Additional Info

Based on master...OlegWock:style-loader:master, but looks like we don't need to handle document here src/runtime/insertBySelector.js

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.26 ⚠️

Comparison is base (382485f) 89.67% compared to head (b1a8837) 89.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   89.67%   89.42%   -0.26%     
==========================================
  Files          15       15              
  Lines         310      312       +2     
  Branches      155      156       +1     
==========================================
+ Hits          278      279       +1     
- Misses         26       27       +1     
  Partials        6        6              
Impacted Files Coverage Δ
src/runtime/isOldIE.js 0.00% <ø> (ø)
src/runtime/singletonStyleDomAPI.js 100.00% <ø> (ø)
src/runtime/styleDomAPI.js 100.00% <ø> (ø)
src/runtime/injectStylesIntoLinkTag.js 95.23% <50.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noop in environment without DOM api
1 participant