Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types #440

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix: types #440

merged 1 commit into from
Sep 2, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 1, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #437

Breaking Changes

No

Additional Info

/cc @gpoitch should fix the problem, wrong types value, can you try locally?

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #440 (5cee2e8) into master (0aadf7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files           4        4           
  Lines         283      283           
  Branches      106      106           
=======================================
  Hits          276      276           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aadf7e...5cee2e8. Read the comment docs.

@gpoitch
Copy link

gpoitch commented Sep 1, 2021

@alexander-akait yes this fixes it for me

@alexander-akait alexander-akait merged commit c6dc40d into master Sep 2, 2021
@alexander-akait alexander-akait deleted the issue-437 branch September 2, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor type error in 5.2.0
2 participants