Fix types incompatibility of PredefinedOptions.ecma and MinifyOptions.ecma #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Fix type conflict for PredefinedOptions.ecma property with MinifyOptions.ecma property from Terser Closes #470
vic-blt
changed the title
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 3 3
Lines 312 312
Branches 114 114
=======================================
Hits 303 303
Misses 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fix type incompatibility for PredefinedOptions.ecma property with
MinifyOptions.ecma property from Terser
Closes #470
Breaking Changes
NA
Additional Info
NA