-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "find in page" or provide alternative means for searching #123
Comments
Hi! Thanks for the issue. I've found myself needing such a feature, too. Unfortunately, currently it is not possible. You're right about the visualizer "not using DOM", because Carrot Search FoamTree (the visualization we use) renders the content to Quickly glancing at the FoamTree API, I couldn't find a way to implement search functionality. I'd be happy to be proven wrong, though 😄 Hopefully I will at some point in the future get #97 completed so that we can have different visualizers. This would allow building something like the one source-map-explorer uses, so that the visualization would be more accessible. Let me know if you have any more questions! |
Thanks for the detailed response @valscion! Would you consider switching to a different treemap renderer? This one looks quite good: webtreemap. It uses the DOM rather than canvas/SVG, which of course means you get the benefits of accessibility. I believe #97 would have allowed for this, but unfortunately that PR now seems to be closed. |
I think it might be a bit of a hassle to move to a different treemap renderer. I'm not sure if it's something @th0r would want to do — if he does, then things might be different. I'm not in the position to make the decision to change the renderer to a different one #97 would've precisely allowed this feature to succeed. Unfortunately I didn't have the motivation nor the time to get that PR to completion. Maybe some day I'll try again |
@OliverJAsh this PR has modules search implemented. It will be merged soon. |
|
Firstly, thanks for the helpful tool!
I want to search the tree for a module to finds its size. The built-in "find in page" browser feature doesn't work, presumably because the DOM is not being used. If that's the case, could this switch to using the DOM? Or, can we provide alternative means for searching the tree?
Note that find in page does work for source-map-explorer.
The text was updated successfully, but these errors were encountered: