Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode optional #642

Open
dsshard opened this issue Oct 21, 2024 · 2 comments
Open

Dark mode optional #642

dsshard opened this issue Oct 21, 2024 · 2 comments

Comments

@dsshard
Copy link

dsshard commented Oct 21, 2024

Hi! This is a super cool product, and often helps me out. Thank you!

I really miss the dark mode, since I often work at night, and the abrupt switch to the "light" tab is very irritating to the eyes.

I made a patch for myself that simply makes the body background #000 and it helps me. But it would be cool to add this as an option for the settings.

Thanks again for the product, you are awesome!

@dsshard
Copy link
Author

dsshard commented Oct 21, 2024

#643

@valscion
Copy link
Member

Yeah a dark mode could be useful. I'd rather avoid adding a new option for it, though — but some sort of a UI feature for a dark mode could be useful.

I could imagine that it'd work like this:

  1. Check localStorage if a light/dark mode setting has been previously selected. If so, use that selection.
  2. Check prefers-color-scheme and use that as a default
  3. Allow user to override what prefers-color-scheme had and persist that to localStorage

The simplest first iteration could be to only add support for prefers-color-scheme and not mess with localStorage at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants