Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

feat: add options validation (schema-utils) #184

Merged
merged 1 commit into from
Sep 29, 2017
Merged

feat: add options validation (schema-utils) #184

merged 1 commit into from
Sep 29, 2017

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Jul 28, 2017

Notable Changes

This PR removes the obsolete options handling for this.options.fileLoader (webpack =< v1.0.0)

webpack.config.js

const config = {
  module: {
    loaders: [
     { 
        test: /\.(png|jpg)$/,
        loader: 'file-loader'
      }
    ]
  },
  fileLoader: {...options} // Invalid in webpack >= v2.0.0
}

@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #184 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   97.43%   96.96%   -0.47%     
==========================================
  Files           2        2              
  Lines          39       33       -6     
  Branches       18       16       -2     
==========================================
- Hits           38       32       -6     
  Misses          1        1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b205b...9609d18. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants