Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addStyles): correctly check singleton behavior when {Boolean} (options.singleton) #285

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 7, 2017

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

yes

If relevant, did you update the README?

yes, we don't have singleton option in table options, i don't know how it is happens

Summary

When singleton: true - i want to use one style tag.
When singleton: false - i want to use multiple style tags.
When singleton not specify (i.e. undefined) - i want the loader himself decide to use single or multiple style tags.

Issue: #283

Does this PR introduce a breaking change?

No

Other information

@alexander-akait
Copy link
Member Author

alexander-akait commented Dec 7, 2017

Btw be great to ensure isOldIE called or not using sinon, i try to found how to test this.
Seems this can not be done with sinon, we can add tests when migrate to jest.

@alexander-akait alexander-akait added this to the 0.19.1 milestone Dec 7, 2017
@michael-ciniawsky michael-ciniawsky changed the title fix: singleton option behavior when boolean fix(addStyles): correctly check singleton behavior when {Boolean} (options.singleton) Dec 14, 2017
@michael-ciniawsky michael-ciniawsky merged commit 2bfc93e into master Dec 14, 2017
@michael-ciniawsky michael-ciniawsky deleted the issue-283 branch December 14, 2017 09:26
@michael-ciniawsky michael-ciniawsky removed this from the 0.20.2 milestone Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants