Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: semantic-release script tries to push old tag #428

Closed
DanielRuf opened this issue May 2, 2018 · 8 comments
Closed

Bug: semantic-release script tries to push old tag #428

DanielRuf opened this issue May 2, 2018 · 8 comments

Comments

@DanielRuf
Copy link
Contributor

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
The semantic-release npm script seems to push an old tag which could be caused by the loaded Travis cache.

If the current behavior is a bug, please provide the steps to reproduce.

Take a look at the CI builds and see that the semantic-release script pushed old tags.
https://travis-ci.org/webpack/webpack-cli/jobs/373140151#L4934-L4975

What is the expected behavior?
The semantic-release script should use the latest version.

If this is a feature request, what is motivation or use case for changing the behavior?

Please paste the results of webpack-cli info here, and mention other relevant information such as programming language.

@ematipico
Copy link
Contributor

This is due to the actual process that we set up in our CI. We are going to change it in the next few days in order to achieve an agreement and set on stone how the release process will work.

The gist is, we want to release through CI in order to automate the shipping of the code. Although we have to make sure that the PRs don't get merged into master. Probably we will switch to a real git flow: merge PRs against develop and merge into master when we are ready to cut a release. Although we will need to change Travis matrix

@evenstensberg
Copy link
Member

We have two scenarios, one is to only use matrices, the other one being build steps. Build steps and matrices doesn't work well together.

@DanielRuf
Copy link
Contributor Author

DanielRuf commented May 4, 2018

Hm, what is the better option? I guess build steps for more complex and flexible configurations.

@evenstensberg
Copy link
Member

Build steps are nice

@DanielRuf
Copy link
Contributor Author

ev1stensberg (Even Stensberg) closed this an hour ago

Do we still need build steps?

@evenstensberg
Copy link
Member

I don't think so, we've set one up now. If you wanna help out, please have a go at #471. I'll be here if you need help 👍 Also, that should be submitted to the next branch, not master

@DanielRuf
Copy link
Contributor Author

Understood, thanks so far.

@evenstensberg
Copy link
Member

Started some work on this at #475 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants