Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: etag support #1797

Merged
merged 5 commits into from
Mar 28, 2024
Merged

feat: etag support #1797

merged 5 commits into from
Mar 28, 2024

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Support ETag generation

fixes #738
fixes #746

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 84.78261% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 93.20%. Comparing base (f69b638) to head (448d76b).

Files Patch % Lines
src/utils/parseTokenList.js 54.16% 9 Missing and 2 partials ⚠️
src/middleware.js 89.15% 6 Missing and 3 partials ⚠️
src/utils/etag.js 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
- Coverage   95.55%   93.20%   -2.35%     
==========================================
  Files          10       12       +2     
  Lines         495      633     +138     
  Branches      135      187      +52     
==========================================
+ Hits          473      590     +117     
- Misses         21       37      +16     
- Partials        1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETag support
1 participant