Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are images that are not in the same folder not recognized? #488

Open
ooker777 opened this issue Jul 9, 2024 · 6 comments
Open

Why are images that are not in the same folder not recognized? #488

ooker777 opened this issue Jul 9, 2024 · 6 comments

Comments

@ooker777
Copy link
Contributor

ooker777 commented Jul 9, 2024

It seems that only images in the same folder are recognized. If it's in the parent then it won't work. Is this a conscious choice or you don't have the time to work on it?

@webpro
Copy link
Owner

webpro commented Jul 9, 2024

It was a conscious choice to keep things simple. Assets and images should be in the same or sub folders.

@ooker777
Copy link
Contributor Author

ooker777 commented Jul 9, 2024

I get that it is indeed simple. But in my project I'd like to keep the image folder and note folder separated, as there are images shared by various notes. Those notes can be in their own subfolders. So having to duplicate the images will make noise when I need to manage the notes only, and hard to keep track the version. In that case do you think it's better to allow the relative path to access parent directories?

@webpro
Copy link
Owner

webpro commented Jul 9, 2024

The challenge was that reveal-md is basically a simple http server that serves static assets and also allows to export it all as a stand-alone HTML website.

Feel free to take a stab at it though, I'm happy to review PRs.

@ooker777
Copy link
Contributor Author

I'm still not sure what simplicity this achieves. Is it for the users or for the devs? I'm not working on it yet, but I imagine it should be no problem for the server to get files from parents?

@webpro
Copy link
Owner

webpro commented Jul 10, 2024

In the end it's just putting in the work to achieve something. I once had this idea to build something that allows to write Markdown and spin up a Reveal.js deck. It does what I need. Other can use it too. Others can contribute too. This is where we are today :)

@ooker777
Copy link
Contributor Author

Yeah I understand that. I just want to know why you make that decision, that's all. Not intend to ask you to work on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants