Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No delete button on failed or successful workflow #2122

Open
tkrn opened this issue Oct 29, 2024 · 3 comments
Open

[Bug]: No delete button on failed or successful workflow #2122

tkrn opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
bug Something isn't working front end Requires front end dev work

Comments

@tkrn
Copy link

tkrn commented Oct 29, 2024

Browsertrix Version

v1.12.0-6032e28

What did you expect to happen? What happened instead?

After a workflow has failed, the ability to delete the workflow does not appear in the UI. Once the crawl has failed, even after removal of that crawl it leaves the workflow in a failed state. Once in that state, the option to be able to delete the workflow goes away from the UI.

Reproduction instructions

  1. Start a new workflow.
  2. If there is an error, the workflow stops, it waits, then reports failed. Once it's reported failed, remove that particular crawl job.
  3. Press "Actions", the "Delete Workflow" is not showing when I expect it to be shown.

Screenshots / Video

Failed workflow, crawls removed successfully but unable to remove workflow.
browsertrix-failed-workflow

Non-started workflow being able to be removed.
browsertrix-failed-workflow-ok

Once the crawl is removed, going out and back into the workflow produces the following load error along with not being able to delete it.
browsertrix-failed-log

Environment

No response

Additional details

No response

@tkrn tkrn added the bug Something isn't working label Oct 29, 2024
@tkrn
Copy link
Author

tkrn commented Oct 30, 2024

Additionally, you can manually do a DELETE on the object via the API and it removes it successfully. Its a matter of showing/hiding the delete button. Upon loads, it appears that the API is called "/errors?page=1&pageSize=50" at page load and comes back with a 404.

@tkrn tkrn changed the title [Bug]: No delete button on failed workflow [Bug]: No delete button on failed or successful workflow Oct 31, 2024
@tkrn
Copy link
Author

tkrn commented Oct 31, 2024

I just observed that this is happening even after a successful workflow, the crawl has been deleted and there is no deleting of a workflow:
2024-10-30_21-31-36

@Shrinks99
Copy link
Member

Thanks for filing this. I've been meaning to make an issue about it but haven't gotten around to it yet!

@Shrinks99 Shrinks99 added the front end Requires front end dev work label Oct 31, 2024
@SuaYoo SuaYoo self-assigned this Nov 4, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end dev work
Projects
Status: Todo
Development

No branches or pull requests

3 participants