Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L10N]: Numbers and dates always formatted in English #2143

Closed
SuaYoo opened this issue Nov 12, 2024 · 0 comments · Fixed by #2146
Closed

[L10N]: Numbers and dates always formatted in English #2143

SuaYoo opened this issue Nov 12, 2024 · 0 comments · Fixed by #2146
Assignees
@SuaYoo
Labels
front end Requires front end dev work localization Related to supporting multiple languages and regions

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Nov 12, 2024 •
edited
Loading

Context

Since numbers and dates use getLocale() from lit, they're always formatted in English, which is the default locale. We need to figure out how to best balance localization for the language that the user selects for their browser with the languages our app supports via translations.

Additionally, numbers that are formatted with toLocaleString should be updated to use whatever approach we land on.
@SuaYoo SuaYoo self-assigned this Nov 12, 2024
@SuaYoo SuaYoo converted this from a draft issue Nov 12, 2024
@SuaYoo SuaYoo added the front end Requires front end dev work label Nov 12, 2024
@SuaYoo SuaYoo changed the title Fix numbers and dates always formatted in English [Bug]: Numbers and dates always formatted in English Nov 12, 2024
@SuaYoo SuaYoo changed the title [Bug]: Numbers and dates always formatted in English [L10N]: Numbers and dates always formatted in English Nov 12, 2024
@SuaYoo SuaYoo added the localization Related to supporting multiple languages and regions label Nov 12, 2024
This was referenced Nov 12, 2024
Merged
Closed
Merged
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Nov 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
front end Requires front end dev work localization Related to supporting multiple languages and regions
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Localize dates, bytes, and numbers webrecorder/browsertrix
1 participant
@SuaYoo